Validate options in dev mode #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
reviewed
Aug 19, 2024
lib/sentry.ex
Outdated
| @@ -335,7 +335,7 @@ defmodule Sentry do | |||
| Client.send_event(event, opts) | |||
|
|
|||
| !Config.dsn() -> | |||
| :ignored | |||
| Client.validate_and_ignore(opts) | |||
There was a problem hiding this comment.
This is gonna make it harder to track the return value–I have to jump to another module. Maybe we can do
Client.validate_options!(opts)
:ignoredinstead?
lib/sentry/client.ex
Outdated
| @@ -160,6 +160,12 @@ defmodule Sentry.Client do | |||
| end | |||
| end | |||
|
|
|||
| @spec validate_and_ignore(keyword()) :: :ignored | |||
| def validate_and_ignore(opts) when is_list(opts) do | |||
There was a problem hiding this comment.
We can also re-use this function above where we call NimbleOptions.validate! if we change it to return the options, like suggested in the other comment.
test/sentry_test.exs
Outdated
Comment on lines
125
to
127
| assert_raise(NimbleOptions.ValidationError, fn -> | ||
| Sentry.Client.validate_and_ignore(client: [bad_key: :nada]) | ||
| end) |
There was a problem hiding this comment.
Nit:
Suggested change
| assert_raise(NimbleOptions.ValidationError, fn -> | |
| Sentry.Client.validate_and_ignore(client: [bad_key: :nada]) | |
| end) | |
| assert_raise NimbleOptions.ValidationError, fn -> | |
| Sentry.Client.validate_and_ignore(client: [bad_key: :nada]) | |
| end |
test/sentry_test.exs
Outdated
| Sentry.Client.validate_and_ignore(client: [bad_key: :nada]) | ||
| end) | ||
|
|
||
| assert :ignored == Sentry.Client.validate_and_ignore(client: :hackney) |
There was a problem hiding this comment.
Nit, but matches other tests:
Suggested change
| assert :ignored == Sentry.Client.validate_and_ignore(client: :hackney) | |
| assert :ignored = Sentry.Client.validate_and_ignore(client: :hackney) |
savhappy
force-pushed
the
sav/validate-all-params-in-all-modes
branch
from
7653b87 to
01bf409
Compare
whatyouhide
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-validate all options passed to send_event even when in dev mode
-closes #766