Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix mentions to 'all events' #350

Merged
merged 1 commit into from
May 19, 2021

Conversation

rhcarvalho
Copy link
Contributor

When the examples and accompanying documentation were written, 'all events' meant 'error events'.

With transactions added to the SDK, BeforeSend is only applied to error events while all EventProcessor functions (on client, scope or global) are applied to all outgoing events (errors and transactions).

When the examples and accompanying documentation were written, 'all
events' meant 'error events'.  With transactions added to the SDK,
BeforeSend is only applied to error events while all EventProcessor
functions (on client, scope or global) are applied to all outgoing
events (errors and transactions).
@rhcarvalho rhcarvalho enabled auto-merge (squash) May 19, 2021 16:51
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge without addressing comment, just a nit. LGTM.

Comment on lines +83 to +85
// Solution 2 (use custom integration, which will be
// applied to all events, and can be extracted as a
// separate utility and reused across projects):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Think this flows better

Suggested change
// Solution 2 (use custom integration, which will be
// applied to all events, and can be extracted as a
// separate utility and reused across projects):
// Solution 2 (use custom integration, which will be
// applied to all events, can be extracted as a
// separate utility, and reused across projects):

@rhcarvalho rhcarvalho merged commit daca7e3 into master May 19, 2021
@rhcarvalho rhcarvalho deleted the docs-beforesend-vs-eventprocessors branch May 19, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants