fix(tracing): Make Span.Finish a no-op when the span is already finished #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 80.61% 80.60% -0.01%
==========================================
Files 43 43
Lines 4338 4337 -1
==========================================
- Hits 3497 3496 -1
Misses 714 714
Partials 127 127
☔ View full report in Codecov by Sentry. |
cleptric
approved these changes
Jul 5, 2023
tracing.go
Outdated
| // (incorrectly) calling it twice never double sends to Sentry. | ||
|
|
||
| // doFinish runs the actual Span.Finish() logic. | ||
| func (s *Span) doFinish() { |
There was a problem hiding this comment.
For readability, can you move this below Finish()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span.Finish() should only be executed once, all the further executions should be no-ops. This should also prevent potential data races when Finish() is (erroneously) called concurrently.
Closes #587