-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(performance): start transaction for echo middleware/integration #722
feat(performance): start transaction for echo middleware/integration #722
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #722 +/- ##
==========================================
+ Coverage 81.59% 81.76% +0.16%
==========================================
Files 48 48
Lines 4717 4759 +42
==========================================
+ Hits 3849 3891 +42
Misses 728 728
Partials 140 140 ☔ View full report in Codecov by Sentry. |
@aldy505 is there any news regarding the implementation? I could really use this |
Michi (@cleptric) said to me a few weeks (or month?) ago over Discord that the Go SDK would need to prioritize to convert every performance section to use OpenTelemetry under the hood first before any other changes. That.. would mean this PR is on hold until the performance section is refactored. Now, for you, would obviously not a good idea to wait for this PR to be merged. But one thing you can do is to copy and paste everything inside the |
Since the perf by otel is on halt, here's a gentle ping @cleptric |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Any chance you could add a changelog entry?
@vaind in 3-4 hours from now |
Closes #642
Let me know if I should also edit
CHANGELOG.md
too.