Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update sentry-native to 0.4.4 #1039

Merged
merged 2 commits into from
Nov 12, 2020
Merged

feat: Update sentry-native to 0.4.4 #1039

merged 2 commits into from
Nov 12, 2020

Conversation

Swatinem
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Updating to the latest sentry-native release, and making sure it is built as dynamic library.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor

it didn't work, I can see this on travis ci:

[55/56] Linking CXX static library sentry_build/libsentry.a
[56/56] Linking CXX shared library ../../../../build/intermediates/cmake/release/obj/x86_64/libnative-sample.so

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set(SENTRY_BUILD_SHARED_LIBS ON) only doesnt work

@marandaneto
Copy link
Contributor

marandaneto commented Nov 12, 2020

also appveyor:
[54/55] Linking CXX static library sentry_build\libsentry.a
[55/55] Linking CXX shared library ........\build\intermediates\cmake\release\obj\arm64-v8a\libnative-sample.so
Build native-sample_x86

I downloaded the artifact from appveyor and didn't see libsentry.so

@Swatinem
Copy link
Member Author

I get this on travis now:

[54/55] Linking CXX shared library ../../../../build/intermediates/cmake/debug/obj/armeabi-v7a/libsentry.so

@marandaneto
Copy link
Contributor

can confirm. thanks

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit c1c9c30 into main Nov 12, 2020
@marandaneto marandaneto deleted the feat/update-native branch November 12, 2020 19:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants