-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update sentry-native to 0.4.4 #1039
Conversation
it didn't work, I can see this on travis ci: [55/56] Linking CXX static library sentry_build/libsentry.a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set(SENTRY_BUILD_SHARED_LIBS ON)
only doesnt work
also appveyor: I downloaded the artifact from appveyor and didn't see libsentry.so |
I get this on travis now:
|
can confirm. thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📢 Type of change
📜 Description
Updating to the latest sentry-native release, and making sure it is built as dynamic library.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps