-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Clean up JNI code and properly free strings #1050
Conversation
looks good, missing a changelog and filling up the PR template |
Codecov Report
@@ Coverage Diff @@
## main #1050 +/- ##
=========================================
Coverage 72.06% 72.06%
Complexity 1338 1338
=========================================
Files 138 138
Lines 4893 4893
Branches 499 499
=========================================
Hits 3526 3526
Misses 1106 1106
Partials 261 261 Continue to review full report at Codecov.
|
I noticed it when investigating, yes |
niiice, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
Missing a changelog entry I.e:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📢 Type of change
📜 Description
This cleans up the JNI layer, removes some unused things like the global transport options, and makes sure to clean up utf strings that have been created.
💡 Motivation and Context
Avoids potential memory leaks and cleans up obsolete code.
💚 How did you test it?
📝 Checklist
🔮 Next steps