Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clean up JNI code and properly free strings #1050

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Nov 17, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This cleans up the JNI layer, removes some unused things like the global transport options, and makes sure to clean up utf strings that have been created.

💡 Motivation and Context

Avoids potential memory leaks and cleans up obsolete code.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor

looks good, missing a changelog and filling up the PR template Motivation and Context, is this related to the memory corruption thingie?

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #1050 (666c03e) into main (01cfbfe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1050   +/-   ##
=========================================
  Coverage     72.06%   72.06%           
  Complexity     1338     1338           
=========================================
  Files           138      138           
  Lines          4893     4893           
  Branches        499      499           
=========================================
  Hits           3526     3526           
  Misses         1106     1106           
  Partials        261      261           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01cfbfe...04e05eb. Read the comment docs.

@Swatinem
Copy link
Member Author

is this related to the memory corruption thingie?

I noticed it when investigating, yes

@marandaneto
Copy link
Contributor

is this related to the memory corruption thingie?

I noticed it when investigating, yes

niiice, thank you!

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@bruno-garcia
Copy link
Member

Missing a changelog entry

I.e:

  • Removing a ton of leaks

:trollface:

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 26f4693 into main Nov 18, 2020
@marandaneto marandaneto deleted the fix/clean-jni branch November 18, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants