Performance: Refactor resolving SpanContext for Throwable

[maciejwalkowiak]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

📜 Description

Refactor resolving SpanContext for Throwable

💡 Motivation and Context

Previous implementation would fail once we switch to sending individual spans. Here we keep an association between throwable and SpanContext on the Hub which is independent from transaction or span being still in memory.

💚 How did you test it?

Integration tests cover it.

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• All tests passing
• No breaking changes

[codecov-io]

Codecov Report

Merging #1068 (4d11d9c) into main (bb58d45) will decrease coverage by 0.46%.
The diff coverage is 43.47%.

@@             Coverage Diff              @@
##               main    #1068      +/-   ##
============================================
- Coverage     73.17%   72.71%   -0.47%     
+ Complexity     1542     1516      -26     
============================================
  Files           162      161       -1     
  Lines          5510     5461      -49     
  Branches        562      548      -14     
============================================
- Hits           4032     3971      -61     
- Misses         1189     1199      +10     
- Partials        289      291       +2     

Impacted Files	Coverage Δ	Complexity Δ
sentry/src/main/java/io/sentry/HubAdapter.java	8.62% <0.00%> (-0.48%)	4.00 <0.00> (ø)
sentry/src/main/java/io/sentry/IHub.java	80.00% <ø> (ø)	8.00 <0.00> (ø)
sentry/src/main/java/io/sentry/Hub.java	63.89% <14.28%> (-0.84%)	69.00 <0.00> (ø)
...try/src/main/java/io/sentry/SentryTransaction.java	94.00% <33.33%> (+1.01%)	23.00 <0.00> (-3.00)	⬆️
...java/io/sentry/spring/SentryExceptionResolver.java	88.88% <50.00%> (+12.88%)	3.00 <0.00> (-2.00)	⬆️
sentry/src/main/java/io/sentry/NoOpHub.java	58.33% <100.00%> (+5.39%)	21.00 <2.00> (+3.00)
sentry/src/main/java/io/sentry/Span.java	88.88% <100.00%> (-4.45%)	10.00 <2.00> (ø)
...sentry/spring/tracing/TransactionNameProvider.java	66.66% <0.00%> (-33.34%)	2.00% <0.00%> (-1.00%)
...entry/src/main/java/io/sentry/SentryBaseEvent.java	72.72% <0.00%> (-18.19%)	14.00% <0.00%> (-4.00%)
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb58d45...d8f984c. Read the comment docs.

[maciejwalkowiak]

@bruno-garcia @marandaneto please take a look.

[maciejwalkowiak]

As far as I can tell covecov reports are broken. Since we have a check for code coverage in gradle build already, could we turn it off?

[bruno-garcia]

🚀