Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enc: Add more convenient method to start child span. #1073

Merged
merged 6 commits into from
Nov 27, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add more convenient method to start child span.

💡 Motivation and Context

getsentry/sentry-docs#2715 (comment)

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maciejwalkowiak and others added 3 commits November 26, 2020 13:55
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
@codecov-io
Copy link

Codecov Report

Merging #1073 (749ad1d) into main (d2ebce9) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1073      +/-   ##
============================================
+ Coverage     73.17%   73.21%   +0.04%     
- Complexity     1542     1545       +3     
============================================
  Files           162      162              
  Lines          5510     5519       +9     
  Branches        562      562              
============================================
+ Hits           4032     4041       +9     
  Misses         1189     1189              
  Partials        289      289              
Impacted Files Coverage Δ Complexity Δ
...try/src/main/java/io/sentry/SentryTransaction.java 93.84% <100.00%> (+0.86%) 28.00 <2.00> (+2.00)
sentry/src/main/java/io/sentry/Span.java 93.75% <100.00%> (+0.41%) 11.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ebce9...749ad1d. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 77115a3 into main Nov 27, 2020
@maciejwalkowiak maciejwalkowiak deleted the start-child-overload branch November 27, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants