Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Simplify ITransport creation in ITransportFactory. #1135

Merged
merged 4 commits into from
Dec 23, 2020
Merged

Ref: Simplify ITransport creation in ITransportFactory. #1135

merged 4 commits into from
Dec 23, 2020

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Simplifies transport creation through passing common request properties that must be applied to HTTP requests in each transport implementation.

💡 Motivation and Context

Reduce boilerplate and simplify creating alternative transport implementations.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

marandaneto
marandaneto approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 28a0068 into gh-1097-rate-limiter Dec 23, 2020
@maciejwalkowiak maciejwalkowiak deleted the gh-1097-request-details branch December 23, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejwalkowiak @marandaneto