Support SENTRY_TRACES_SAMPLE_RATE conf. via env variables. #1171
Conversation
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1171 +/- ##
============================================
+ Coverage 75.25% 75.27% +0.02%
- Complexity 1662 1665 +3
============================================
Files 173 173
Lines 5812 5817 +5
Branches 568 570 +2
============================================
+ Hits 4374 4379 +5
Misses 1174 1174
Partials 264 264
Continue to review full report at Codecov.
|
| @Nullable | ||
| default Double getDoubleProperty(final @NotNull String property) { | ||
| final String result = getProperty(property); | ||
| return result != null ? Double.valueOf(result) : null; |
There was a problem hiding this comment.
should we account if it's not a Double? like catch NumberFormatException and return null?
There was a problem hiding this comment.
Given this is done at startup and the value must be double, probably OK to blow up here
There was a problem hiding this comment.
that's o but kinda goes against our philosophy
https://develop.sentry.dev/sdk/philosophy/#degrade-gracefully
I'd prefer blowing up only if there's no DSN, any other reason would be a bug IMO
| @Nullable | ||
| default Double getDoubleProperty(final @NotNull String property) { | ||
| final String result = getProperty(property); | ||
| return result != null ? Double.valueOf(result) : null; |
There was a problem hiding this comment.
Given this is done at startup and the value must be double, probably OK to blow up here
📜 Description
Support SENTRY_TRACES_SAMPLE_RATE conf. via env variables.
💡 Motivation and Context
Fixes #1169
💚 How did you test it?
Unit tests.
📝 Checklist