Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SentrySpanClientHttpRequestInterceptor to Spring module. #1181

Merged
merged 7 commits into from
Jan 18, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Move SentrySpanClientHttpRequestInterceptor to Spring module.

💡 Motivation and Context

Simplify using performance feature for Spring (non-boot) users.

Fixes #1178.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #1181 (c552dea) into main (bba0c16) will decrease coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1181      +/-   ##
============================================
- Coverage     75.28%   74.85%   -0.43%     
+ Complexity     1665     1657       -8     
============================================
  Files           173      173              
  Lines          5818     5818              
  Branches        571      571              
============================================
- Hits           4380     4355      -25     
- Misses         1174     1200      +26     
+ Partials        264      263       -1     
Impacted Files Coverage Δ Complexity Δ
.../spring/boot/SentrySpanRestTemplateCustomizer.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba0c16...60c058f. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejwalkowiak maciejwalkowiak merged commit 2f8360a into main Jan 18, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1178 branch January 18, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentrySpanClientHttpRequestInterceptor should be in sentry-spring instead of sentry-spring-boot-starter
3 participants