Auto register custom ITransportFactory in Spring integration. #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
approved these changes
Jan 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
============================================
+ Coverage 74.70% 74.71% +0.01%
Complexity 1677 1677
============================================
Files 176 176
Lines 5887 5890 +3
Branches 574 574
============================================
+ Hits 4398 4401 +3
Misses 1225 1225
Partials 264 264
Continue to review full report at Codecov.
|
| @Test | ||
| fun `configures custom TransportFactory`() { | ||
| ApplicationContextRunner().withConfiguration(UserConfigurations.of(AppConfigWithCustomTransportFactory::class.java)) | ||
| .run { |
There was a problem hiding this comment.
This require a note on the docs?
There was a problem hiding this comment.
It's included in getsentry/sentry-docs#2833
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Auto register custom ITransportFactory in Spring integration.
💡 Motivation and Context
For users who prefer to use Apache Http Client based transport, we have to provide convenient way of registering alternative transport factories.
💚 How did you test it?
Unit test.
📝 Checklist