-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support logging via JUL #1211
Support logging via JUL #1211
Conversation
Afterthought - for the backward compatibility we should also support MDC tags, which means we need a dependency for SLF4J, which means that JUL appender would have to go to separate module. |
Codecov Report
@@ Coverage Diff @@
## main #1211 +/- ##
============================================
- Coverage 74.62% 74.57% -0.06%
- Complexity 1682 1713 +31
============================================
Files 176 177 +1
Lines 5908 6029 +121
Branches 578 600 +22
============================================
+ Hits 4409 4496 +87
- Misses 1234 1256 +22
- Partials 265 277 +12
Continue to review full report at Codecov.
|
Sorry but I don't follow. before it wasnt' a separate package, so why does it need to be now for backwards compat? |
adding a dependency of |
As @marandaneto said, since 3.x we do not have slf4j dependency in the SDK core. I am not really sure how people use slf4j AND jul at the same time, but since it was in 1.x and it's also in handler added to Quarkus, I think we should follow the same path. |
makes sense |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments but looks good and ready to go.
LGTM
The next step would be to create docs too, probably linking to the migration page.
@maciejwalkowiak CI is not happy |
📜 Description
Support logging via JUL + sample project.
💡 Motivation and Context
Fixes #1037
💚 How did you test it?
Unit & Integration tests.
📝 Checklist
🔮 Next steps
Create a PR in Quarkus or let know Quarkus team about JUL logger in Sentry SDK, so that they do not need to maintain their custom one.