Fix returning Sentry trace header from Span. #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpanId for Sentry header should be taken from the Span itself and not from the parent transaction.
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
|
I'll do first a test if this renders correctly in the UI now. |
Create trace header from the current span, not from the parent.
|
After fix, the "Child Span" button is shown. |
marandaneto
approved these changes
Feb 1, 2021
bruno-garcia
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix returning Sentry trace header from Span.
💡 Motivation and Context
SpanId for Sentry header should be taken from the Span itself and not from the parent transaction.
Fix #1216
💚 How did you test it?
Unit tests.
📝 Checklist