-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Mark stacktrace as snapshot if captured at arbitrary moment #1231
Conversation
@jan-auer added you as a reviewer just to be aware that we are adding it to Android/Java |
@jan-auer is it correct to assume that This is what we're aiming for ANR and if that's not what |
@bruno-garcia Since |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just made a few minor comments.
sentry-android-core/src/test/java/io/sentry/android/core/AnrIntegrationTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AnrIntegrationTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AnrIntegrationTest.kt
Show resolved
Hide resolved
@marandaneto Good point, this is ambiguous terminology. With "top" I always mean the inner-most frame. |
📜 Description
Fix: Mark stacktrace as snapshot if captured at arbitrary moment
💡 Motivation and Context
ANR stack traces and the thread list attach a stack trace captured at an arbitrary moment and this could affect grouping, this flag will be used for better grouping, maybe using hierarchical grouping or something else on the server-side.
💚 How did you test it?
📝 Checklist
🔮 Next steps