Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NoOpHub public #1372

Closed
wants to merge 1 commit into from
Closed

Make NoOpHub public #1372

wants to merge 1 commit into from

Conversation

egalpin
Copy link

@egalpin egalpin commented Apr 1, 2021

📜 Description

Makes NoOpHub public.

💡 Motivation and Context

This enables easier resource management in an Apache Beam use case that I have. In Beam, I must manage an IHub manually rather than using static methods in Sentry. Allowing end-users to create NoOpHub instances will provide the kind of flexibility needed for this kind of use case.

If there is currently a method by which I can create an instance of NoOpHub directly, please point it out and close this PR. Thanks!

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

This enables easier resource management in an Apache Beam use case that I have.
@maciejwalkowiak
Copy link
Contributor

I think we can make it public. @marandaneto @bruno-garcia?

@marandaneto
Copy link
Contributor

I think we can make it public. @marandaneto @bruno-garcia?

I think it's fine but I quite didn't understand why it's necessary.

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@egalpin please run ./gradlew apiDump. It will create a file listing changes in the public API. Then add the change and push. Once it's there the build should pass.

@egalpin
Copy link
Author

egalpin commented Apr 6, 2021

I just ran ./gradlew apiDump but ran into a failure:

A problem occurred configuring project ':sentry-android-ndk'.
> SDK location not found. Define location with an ANDROID_SDK_ROOT environment variable or by setting the sdk.dir path in your project's local properties file at '/me/code/sentry-java/local.properties'.

Do I need to have the Android SDK installed? I'd prefer not to haha. Is there an automated build system I could leverage? Also feel free to push directly to this PR as needed if that's a path to a resolution 🙂 Thanks!

@marandaneto
Copy link
Contributor

in favor of #1379

@marandaneto marandaneto closed this Apr 7, 2021
@marandaneto marandaneto mentioned this pull request Apr 7, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants