Fix: SentryTransactionAdvice should operate on the new scope.
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maciejwalkowiak changelog and mind updating the issue's description about why do we need that? I am fine with the changes but I don't know why its required to be in a new scope |
|
@marandaneto updated. |
marandaneto
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix:
SentryTransactionAdviceshould operate on the new scope.💡 Motivation and Context
@SentryTransactionis meant to be used for integrations that we do not support out of the box like messaging, scheduled jobs. These integrations work on thread pools, meaning if users modify the scope, without having push & pop scope changes would last also for further invocations happening on the same thread.💚 How did you test it?
Unit tests.
📝 Checklist