Fix: use connection and read timeouts in ApacheHttpClient based transport #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
commented
Apr 13, 2021
...-client-5/src/test/kotlin/io/sentry/transport/apache/ApacheHttpClientTransportFactoryTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 14, 2021
...-client-5/src/test/kotlin/io/sentry/transport/apache/ApacheHttpClientTransportFactoryTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
reviewed
Apr 14, 2021
...-client-5/src/test/kotlin/io/sentry/transport/apache/ApacheHttpClientTransportFactoryTest.kt
Outdated
Show resolved
Hide resolved
marandaneto
approved these changes
Apr 14, 2021
…try/sentry-java into apache-transport-timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fix: use connection and read timeouts in ApacheHttpClient based transport
💡 Motivation and Context
When
ApacheHttpClientTransportwas used, timeouts were not respected.💚 How did you test it?
Console sample and slowing down connections with ToxiProxy connected to Sentry relay running locally.
📝 Checklist