-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: associate event with transaction when thrown exception is not a direct cause #1463
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1463 +/- ##
============================================
- Coverage 75.83% 75.83% -0.01%
- Complexity 1901 1903 +2
============================================
Files 189 190 +1
Lines 6502 6509 +7
Branches 640 641 +1
============================================
+ Hits 4931 4936 +5
- Misses 1275 1276 +1
- Partials 296 297 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make sure setThrowable
now uses the reference of the rootCause instead of the one taken by parameter.
Other than that LGTM
I thought it through over the weekend and realised the missing scenario. Please take a look @marandaneto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Fix: associate event with transaction when thrown exception is not a direct cause
💡 Motivation and Context
Fixes #1418
💚 How did you test it?
Unit tests.
📝 Checklist