-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling immutable collections on SentryEvent and protocol objects #1468
Conversation
worth doing the same with |
Codecov Report
@@ Coverage Diff @@
## main #1468 +/- ##
============================================
+ Coverage 75.62% 75.83% +0.21%
- Complexity 1908 1922 +14
============================================
Files 190 190
Lines 6551 6555 +4
Branches 659 659
============================================
+ Hits 4954 4971 +17
+ Misses 1280 1264 -16
- Partials 317 320 +3
Continue to review full report at Codecov.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if CI is happy, I am happy :)
Thanks @maciejwalkowiak
📜 Description
Fix handling immutable collections on SentryEvent and protocol objects. With this change, when immutable collection is set on any of
SentryEvent
field, it is still possible to add more entries to this collection on the event.💡 Motivation and Context
Fixes #1357
💚 How did you test it?
Unit tests.
📝 Checklist