Feat: Add breadcrumb in Spring RestTemplate integration #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
May 19, 2021
| final @Nullable Integer responseStatusCode) { | ||
| final Breadcrumb breadcrumb = | ||
| Breadcrumb.http(request.getURI().toString(), request.getMethodValue(), responseStatusCode); | ||
| breadcrumb.setData("requestBodySize", body.length); |
There was a problem hiding this comment.
can we read the response and if available, also adding responseBodySize?
There was a problem hiding this comment.
response is an input stream here, to get the size we would need to read it.
Codecov Report
@@ Coverage Diff @@
## main #1481 +/- ##
============================================
- Coverage 75.75% 75.66% -0.10%
Complexity 1926 1926
============================================
Files 190 190
Lines 6580 6588 +8
Branches 665 665
============================================
Hits 4985 4985
- Misses 1270 1278 +8
Partials 325 325
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Feat: Add breadcrumb in Spring RestTemplate integration
💡 Motivation and Context
In the process of alignment
OkHttpintegration with SpringRestTemplateintegration I noticed that we do not add breadcrumb for http request going throughRestTemplate. With this change, breadcrumb is added no matter if there is an active ongoing transaction.💚 How did you test it?
Unit tests.
📝 Checklist