Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Append all threads if Hint is Cached but attachThreads is enabled #1503

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 1, 2021

📜 Description

Fix: Append all threads if Hint is Cached but attachThreads is enabled

💡 Motivation and Context

Ammend to #1501

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #1503 (02b753b) into main (ad283c1) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1503   +/-   ##
=========================================
  Coverage     76.04%   76.04%           
  Complexity     1930     1930           
=========================================
  Files           191      191           
  Lines          6674     6675    +1     
  Branches        664      665    +1     
=========================================
+ Hits           5075     5076    +1     
  Misses         1274     1274           
  Partials        325      325           
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/MainEventProcessor.java 83.49% <33.33%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad283c1...02b753b. Read the comment docs.

@marandaneto marandaneto merged commit 9f9dc24 into main Jun 1, 2021
@marandaneto marandaneto deleted the fix/cached-hint-allthreads branch June 1, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants