-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Add attachmentType to envelope ser/deser. #1504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments. TIL. Didn't know the abbreviation ser/deser.
Codecov Report
@@ Coverage Diff @@
## main #1504 +/- ##
============================================
+ Coverage 76.04% 76.12% +0.07%
- Complexity 1930 1934 +4
============================================
Files 191 191
Lines 6675 6696 +21
Branches 665 666 +1
============================================
+ Hits 5076 5097 +21
Misses 1274 1274
Partials 325 325
Continue to review full report at Codecov.
|
📜 Description
Fix: Add attachmentType to envelope ser/deser.
💡 Motivation and Context
Extract from https://github.com/getsentry/sentry-java/pull/1256/files
💚 How did you test it?
📝 Checklist
🔮 Next steps