Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add attachmentType to envelope ser/deser. #1504

Merged
merged 7 commits into from
Jun 2, 2021

Conversation

marandaneto
Copy link
Contributor

📜 Description

Fix: Add attachmentType to envelope ser/deser.

💡 Motivation and Context

Extract from https://github.com/getsentry/sentry-java/pull/1256/files

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as ready for review June 1, 2021 08:52
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments. TIL. Didn't know the abbreviation ser/deser.

@codecov-commenter
Copy link

Codecov Report

Merging #1504 (90a3cda) into main (ac5797b) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1504      +/-   ##
============================================
+ Coverage     76.04%   76.12%   +0.07%     
- Complexity     1930     1934       +4     
============================================
  Files           191      191              
  Lines          6675     6696      +21     
  Branches        665      666       +1     
============================================
+ Hits           5076     5097      +21     
  Misses         1274     1274              
  Partials        325      325              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Attachment.java 100.00% <100.00%> (ø)
...ry/src/main/java/io/sentry/SentryEnvelopeItem.java 88.78% <100.00%> (+0.10%) ⬆️
.../main/java/io/sentry/SentryEnvelopeItemHeader.java 92.59% <100.00%> (+1.68%) ⬆️
...ava/io/sentry/SentryEnvelopeItemHeaderAdapter.java 74.00% <100.00%> (+3.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac5797b...90a3cda. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants