Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data field to SentrySpan. #1555

Merged
merged 6 commits into from
Jun 24, 2021
Merged

Add data field to SentrySpan. #1555

merged 6 commits into from
Jun 24, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Add data field to SentrySpan.

💡 Motivation and Context

Fixes #1538

💚 How did you test it?

JSON serialization tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@codecov-commenter
Copy link

Codecov Report

Merging #1555 (6ad3559) into main (007cf3d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1555      +/-   ##
============================================
+ Coverage     76.02%   76.03%   +0.01%     
- Complexity     1953     1955       +2     
============================================
  Files           192      192              
  Lines          6760     6764       +4     
  Branches        676      676              
============================================
+ Hits           5139     5143       +4     
  Misses         1294     1294              
  Partials        327      327              
Impacted Files Coverage Δ
...y/src/main/java/io/sentry/protocol/SentrySpan.java 96.29% <100.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 007cf3d...6ad3559. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit 384db09 into main Jun 24, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1538 branch June 24, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentrySpan does not have a data field
3 participants