Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Do not crash if SENSOR_SERVICE throws #1655

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Aug 18, 2021

📜 Description

Fix: Do not crash if SENSOR_SERVICE throws

💡 Motivation and Context

SENSOR_SERVICE may throw for some reason even though it was never reproduceable getsentry/sentry-dart#548

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #1655 (69a67b1) into main (3660e29) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1655   +/-   ##
=========================================
  Coverage     75.77%   75.77%           
  Complexity     2019     2019           
=========================================
  Files           207      207           
  Lines          7045     7045           
  Branches        699      699           
=========================================
  Hits           5338     5338           
  Misses         1369     1369           
  Partials        338      338           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3660e29...69a67b1. Read the comment docs.

@marandaneto
Copy link
Contributor Author

also possibly #1436

@marandaneto marandaneto merged commit bcdb061 into main Aug 19, 2021
@marandaneto marandaneto deleted the fix/sensor-service branch August 19, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants