Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add option to filter which origins receive tracing headers #1698

Merged
merged 8 commits into from
Sep 6, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Add tracingOrigins to SentryOptions and respect it in OkHttp, WebClient and RestTemplate integrations.

💡 Motivation and Context

Fixes #1697
Fixes #1585

💚 How did you test it?

Integration tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 3, 2021 12:08
@maciejwalkowiak
Copy link
Contributor Author

I realised we also need add option to set this property from the external configuration.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #1698 (a0f2e49) into main (717ccad) will increase coverage by 0.03%.
The diff coverage is 69.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1698      +/-   ##
============================================
+ Coverage     74.80%   74.83%   +0.03%     
- Complexity     2077     2086       +9     
============================================
  Files           210      211       +1     
  Lines          7430     7451      +21     
  Branches        782      788       +6     
============================================
+ Hits           5558     5576      +18     
- Misses         1491     1494       +3     
  Partials        381      381              
Impacted Files Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...ring/tracing/SentrySpanClientWebRequestFilter.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/TracingOrigins.java 77.77% <77.77%> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 85.79% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717ccad...a0f2e49. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add allowList for the tracestate header Add support for tracing origins
3 participants