Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Attach Java vendor and version to events and transactions. #1703

Merged
merged 7 commits into from
Sep 28, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 7, 2021

📜 Description

Attach Java vendor and version to events and transactions.

💡 Motivation and Context

Came up once during discussion with @bruno-garcia, that this functionality should be in the core of library and not just as a sample event processor in a Spring Boot sample.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 7, 2021 20:03
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #1703 (732946c) into main (7726602) will increase coverage by 0.06%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1703      +/-   ##
============================================
+ Coverage     75.19%   75.25%   +0.06%     
- Complexity     2126     2135       +9     
============================================
  Files           212      213       +1     
  Lines          7606     7622      +16     
  Branches        807      808       +1     
============================================
+ Hits           5719     5736      +17     
+ Misses         1496     1493       -3     
- Partials        391      393       +2     
Impacted Files Coverage Δ
...in/java/io/sentry/SentryRuntimeEventProcessor.java 93.33% <93.33%> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 85.51% <100.00%> (+0.03%) ⬆️
...o/sentry/adapters/ContextsDeserializerAdapter.java 40.81% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7726602...732946c. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment, other than that, LGTM

@maciejwalkowiak maciejwalkowiak merged commit b8854fe into main Sep 28, 2021
@maciejwalkowiak maciejwalkowiak deleted the sentry-runtime-processor branch September 28, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants