-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Attach Java vendor and version to events and transactions. #1703
Conversation
…t version instead of Java version.
Codecov Report
@@ Coverage Diff @@
## main #1703 +/- ##
============================================
+ Coverage 75.19% 75.25% +0.06%
- Complexity 2126 2135 +9
============================================
Files 212 213 +1
Lines 7606 7622 +16
Branches 807 808 +1
============================================
+ Hits 5719 5736 +17
+ Misses 1496 1493 -3
- Partials 391 393 +2
Continue to review full report at Codecov.
|
sentry/src/main/java/io/sentry/SentryRuntimeEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry/src/main/java/io/sentry/SentryRuntimeEventProcessor.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment, other than that, LGTM
📜 Description
Attach Java vendor and version to events and transactions.
💡 Motivation and Context
Came up once during discussion with @bruno-garcia, that this functionality should be in the core of library and not just as a sample event processor in a Spring Boot sample.
💚 How did you test it?
Unit tests.
📝 Checklist