-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check at runtime if AndroidX.Core is available #1718
Conversation
docs PR getsentry/sentry-docs#4150 |
Codecov Report
@@ Coverage Diff @@
## main #1718 +/- ##
=========================================
Coverage 75.04% 75.04%
Complexity 2099 2099
=========================================
Files 211 211
Lines 7514 7514
Branches 791 791
=========================================
Hits 5639 5639
Misses 1492 1492
Partials 383 383 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I'm sure you were resistant to do the runtime check with reflection but I appreciate as it'll help the unity use case and others.
📜 Description
Check at runtime if AndroidX.Core is available
💡 Motivation and Context
Closes #1711
💚 How did you test it?
running without androidxcore/unit test
📝 Checklist
🔮 Next steps