Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check at runtime if AndroidX.Core is available #1718

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 15, 2021

📜 Description

Check at runtime if AndroidX.Core is available

💡 Motivation and Context

Closes #1711

💚 How did you test it?

running without androidxcore/unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

docs PR getsentry/sentry-docs#4150

@codecov-commenter
Copy link

Codecov Report

Merging #1718 (fcf6a25) into main (7cd5740) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1718   +/-   ##
=========================================
  Coverage     75.04%   75.04%           
  Complexity     2099     2099           
=========================================
  Files           211      211           
  Lines          7514     7514           
  Branches        791      791           
=========================================
  Hits           5639     5639           
  Misses         1492     1492           
  Partials        383      383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd5740...fcf6a25. Read the comment docs.

Copy link
Contributor

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I'm sure you were resistant to do the runtime check with reflection but I appreciate as it'll help the unity use case and others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android SDK crashes on Unity player
5 participants