Feat: Add breadcrumbs for the Apollo integration #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
marandaneto
reviewed
Sep 17, 2021
| @Test | ||
| fun `adds breadcrumb when http calls succeeds`() { | ||
| executeQuery() | ||
| verify(fixture.hub).addBreadcrumb(com.nhaarman.mockitokotlin2.check<Breadcrumb> { |
There was a problem hiding this comment.
Suggested change
| verify(fixture.hub).addBreadcrumb(com.nhaarman.mockitokotlin2.check<Breadcrumb> { | |
| verify(fixture.hub).addBreadcrumb(check<Breadcrumb> { |
we can just import the check extension method
marandaneto
reviewed
Sep 17, 2021
| @@ -30,8 +33,9 @@ class SentryApolloInterceptorTest { | |||
|
|
|||
| class Fixture { | |||
| val server = MockWebServer() | |||
| val hub = spy(HubAdapter.getInstance()) | |||
There was a problem hiding this comment.
out of curiosity, why spy instead of mock?
There was a problem hiding this comment.
Initially it was meant to be full integration test, using coroutines Sentry context. But, since on Android Sentry context does not need to be used, I've changed this test to use mocked hub instead of verifying transport.
marandaneto
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Feat: Add breadcrumbs for the Apollo integration
💡 Motivation and Context
Fixes #1721
💚 How did you test it?
Unit tests.
📝 Checklist