Feat: Allow setting proguard via Options and/or external resources

[maciejwalkowiak]

📜 Description

Allow setting proguard via Options and/or external resources.

UUIDs can be set on options either programmatically or using system properties, environment variables or sentry.properties file - same way as any other external property.

💡 Motivation and Context

Fixes #1236

💚 How did you test it?

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

[codecov-commenter]

Codecov Report

Merging #1728 (e026dc3) into main (ae95ea3) will increase coverage by 0.13%.
The diff coverage is 80.95%.

@@             Coverage Diff              @@
##               main    #1728      +/-   ##
============================================
+ Coverage     75.05%   75.19%   +0.13%     
- Complexity     2115     2126      +11     
============================================
  Files           212      212              
  Lines          7585     7606      +21     
  Branches        803      807       +4     
============================================
+ Hits           5693     5719      +26     
+ Misses         1504     1496       -8     
- Partials        388      391       +3     

Impacted Files	Coverage Δ
...y/src/main/java/io/sentry/protocol/DebugImage.java	21.87% <ø> (+18.75%)	⬆️
sentry/src/main/java/io/sentry/SentryOptions.java	85.47% <66.66%> (-0.32%)	⬇️
...ry/src/main/java/io/sentry/MainEventProcessor.java	83.89% <86.66%> (+0.40%)	⬆️
sentry/src/main/java/io/sentry/SentryEvent.java	79.03% <0.00%> (+4.83%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae95ea3...e026dc3. Read the comment docs.

[marandaneto]

since MainEventProcessor now applies the uuid to the event reading from the options, what's about setting the proguardUUID here to the options and let the MainEventProcessor create the DebugImage?
we only do it if the options isn't set though

[marandaneto]

the other thing to consider is, event processor runs for every event, reading the uuid is a 1-time thing, so maybe it'd also make sense to move this logic from here to somewhere else eg AndroidOptionsInitializer, the downside is that we do IO in the main thread, maybe we keep this refactor for another PR, we just need to tackle the comment above

[maciejwalkowiak]

Here it reads a list of uuids (from all the resources), so it cannot be set on the options, or we change it here to single UUID.

[marandaneto]

we can get just a single id, there's even a comment about that.

https://github.com/getsentry/sentry-java/blob/main/sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java#L911-L912

[maciejwalkowiak]

@marandaneto take a look please if reading order makes sense. Currently first the Proguard UUID is read from the manifest, if not found from sentry-debug-meta.properties.

[marandaneto]

var PROGUARD_UUID can be removed from this class now

[maciejwalkowiak]

Thanks, missed that.