Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close HostnameCache#executorService on SentryClient#close. #1757

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

Fixes #1756.

📜 Description

Close HostnameCache#executorService on SentryClient#close.

💡 Motivation and Context

Fixes #1756.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review October 8, 2021 12:06
Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1757 (5fb81e9) into main (5cf90ef) will decrease coverage by 0.03%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1757      +/-   ##
============================================
- Coverage     75.34%   75.31%   -0.04%     
- Complexity     2158     2165       +7     
============================================
  Files           215      215              
  Lines          7699     7718      +19     
  Branches        820      822       +2     
============================================
+ Hits           5801     5813      +12     
- Misses         1502     1507       +5     
- Partials        396      398       +2     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryClient.java 85.98% <55.55%> (-0.90%) ⬇️
...ry/src/main/java/io/sentry/MainEventProcessor.java 82.40% <57.14%> (-1.50%) ⬇️
sentry/src/main/java/io/sentry/HostnameCache.java 90.00% <100.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf90ef...5fb81e9. Read the comment docs.

@maciejwalkowiak maciejwalkowiak merged commit efed2fe into main Oct 8, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1756 branch October 8, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HostnameCache executorService not shut down
3 participants