Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make ActivityFramesTracker operations thread-safe #1762

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 13, 2021

📜 Description

Fix: Make ActivityFramesTracker operations thread-safe

💡 Motivation and Context

Fixes #1760

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto requested a review from a team October 13, 2021 09:05
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #1762 (7c55b83) into main (23884c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1762   +/-   ##
=========================================
  Coverage     75.31%   75.31%           
  Complexity     2165     2165           
=========================================
  Files           215      215           
  Lines          7718     7718           
  Branches        822      822           
=========================================
  Hits           5813     5813           
  Misses         1507     1507           
  Partials        398      398           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23884c0...7c55b83. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add tests to make sure it is thread safe?

@marandaneto marandaneto merged commit 7fd6b52 into main Oct 14, 2021
@marandaneto marandaneto deleted the fix/concurrency-frames-tracker branch October 14, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-threaded calls in ActivityLifecycleIntegration with SentryOkHttpInterceptor
4 participants