Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ActivityFramesTracker does not throw if Activity has not been added #1782

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Fix: ActivityFramesTracker does not throw if Activity has not been added #1782

merged 2 commits into from
Oct 28, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Oct 25, 2021 •
edited
Loading

📜 Description

Fix: ActivityFramesTracker does not throw if Activity has not been added

💡 Motivation and Context

#1780

💚 How did you test it?

unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto mentioned this pull request Oct 25, 2021
Closed
8 tasks
@marandaneto
Copy link
Contributor Author

@maciejwalkowiak or @romtsn please review

@marandaneto marandaneto merged commit c8f22bd into main Oct 28, 2021
@marandaneto marandaneto deleted the fix/frames-tracker-no-activity branch October 28, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @romtsn