-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add datasource tracing with P6Spy. #1784
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1784 +/- ##
============================================
+ Coverage 75.72% 75.73% +0.01%
- Complexity 2173 2180 +7
============================================
Files 215 216 +1
Lines 7719 7739 +20
Branches 821 824 +3
============================================
+ Hits 5845 5861 +16
- Misses 1474 1477 +3
- Partials 400 401 +1
Continue to review full report at Codecov.
|
@maciejwalkowiak next step is docs under sentry-docs, release-registry and craft configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Craft was done in this PR. Missing release-registry and docs. |
📜 Description
Adds datasource tracing with p6spy.
In comparison to #1095, we do not rely on any 3rd party integration with Spring, we also do not provide any custom integration with Spring. Instead, we use the Java ServiceLoader mechanism to provide an implementation of P6Spy's
JdbcEventListener
.As a result, to use P6Spy and Sentry integration with Spring Boot application, it's enough to:
p6spy
, for example:driver-class-name
property:sentry-p6spy
.💡 Motivation and Context
Missing piece.
💚 How did you test it?
Integration tests and sample app.
📝 Checklist
🔮 Next steps
Depending on the feedback we get, we may also add integration with https://github.com/ttddyy/datasource-proxy, but this will require more changes in Spring configuration, as we would need to post-process the datasource bean like here