-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor OkHttp and Apollo to Kotlin functional interfaces. #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1797 +/- ##
=========================================
Coverage 75.74% 75.74%
Complexity 2194 2194
=========================================
Files 218 218
Lines 7804 7804
Branches 828 828
=========================================
Hits 5911 5911
Misses 1491 1491
Partials 402 402
Continue to review full report at Codecov.
|
That sounds like a nice refactoring, is it a breaking change in Java or Kotlin? or IDE would just point out to simplify the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a comment to be answered otherwise LGTM, thanks!
Tested - non breaking for both Java and Kotlin |
📜 Description
Refactor OkHttp and Apollo to Kotlin functional interfaces.
💡 Motivation and Context
Reduces boilerplate when using callbacks in Kotlin code.
💚 How did you test it?
Already covered with unit tests.
📝 Checklist