Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Only report App start measurement for full launch on Android #1821

Merged
merged 4 commits into from
Nov 30, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 29, 2021

📜 Description

Fix: Only report App start measurement for full launch on Android

💡 Motivation and Context

Closes #1814

💚 How did you test it?

unit tests and LouisFn/SentryFrozenFrame@f6bf546

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto marked this pull request as ready for review November 30, 2021 09:04
@marandaneto
Copy link
Contributor Author

marandaneto commented Nov 30, 2021

docs getsentry/sentry-docs#4447

@codecov-commenter
Copy link

Codecov Report

Merging #1821 (19814b8) into main (5bb6c9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1821   +/-   ##
=========================================
  Coverage     75.72%   75.72%           
  Complexity     2194     2194           
=========================================
  Files           218      218           
  Lines          7806     7806           
  Branches        828      828           
=========================================
  Hits           5911     5911           
  Misses         1493     1493           
  Partials        402      402           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb6c9f...19814b8. Read the comment docs.

@marandaneto marandaneto merged commit 4bd6b08 into main Nov 30, 2021
@marandaneto marandaneto deleted the fix/full-launch branch November 30, 2021 10:01

// we only track app start for processes that will show an Activity (full launch).
// Here we check the process importance which will tell us that.
foregroundImportance = isForegroundImportance(this.application);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, just thinking if this will be called in case of the warm app start? This integration is added in Application.onCreate, which won't be called in case of warm start, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in the ctor of the integration, so it'll be called too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the integration ctor itself - will it be called in case of the warm start, if the process wasn't killed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong duration for AutoActivityLifecycleTracing with WorkManager
3 participants