-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Only report App start measurement for full launch on Android #1821
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1821 +/- ##
=========================================
Coverage 75.72% 75.72%
Complexity 2194 2194
=========================================
Files 218 218
Lines 7806 7806
Branches 828 828
=========================================
Hits 5911 5911
Misses 1493 1493
Partials 402 402 Continue to review full report at Codecov.
|
|
||
// we only track app start for processes that will show an Activity (full launch). | ||
// Here we check the process importance which will tell us that. | ||
foregroundImportance = isForegroundImportance(this.application); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, just thinking if this will be called in case of the warm app start? This integration is added in Application.onCreate
, which won't be called in case of warm start, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's in the ctor of the integration, so it'll be called too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the integration ctor itself - will it be called in case of the warm start, if the process wasn't killed?
📜 Description
Fix: Only report App start measurement for full launch on Android
💡 Motivation and Context
Closes #1814
💚 How did you test it?
unit tests and LouisFn/SentryFrozenFrame@f6bf546
📝 Checklist
🔮 Next steps