-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change java.util.Random to java.security.SecureRandom #1831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's available on Android since API 1 so from that perspective it would be fine.
@maciejwalkowiak @romtsn @marandaneto anything we should be aware before merging?
Nothing to be scared of as far as I am aware in regards to running Sentry SDK on server 👍 |
@mr-africa you dont need to add a new test, since there's already tests in place for that. please run |
@mr-africa test should work but you've to fix the import for the Random class in tests, See |
Codecov Report
@@ Coverage Diff @@
## main #1831 +/- ##
=========================================
Coverage 75.72% 75.72%
Complexity 2194 2194
=========================================
Files 218 218
Lines 7806 7806
Branches 828 828
=========================================
Hits 5911 5911
Misses 1493 1493
Partials 402 402
Continue to review full report at Codecov.
|
📜 Description
change
java.util.Random
tojava.security.SecureRandom
for possible security reasons💡 Motivation and Context
#1830
💚 How did you test it?
📝 Checklist
🔮 Next steps