-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify DateUtils with ISO8601Utils #1837
Conversation
Codecov Report
@@ Coverage Diff @@
## 6.x.x #1837 +/- ##
============================================
- Coverage 80.93% 80.85% -0.09%
- Complexity 2850 2878 +28
============================================
Files 207 208 +1
Lines 10475 10613 +138
Branches 1380 1411 +31
============================================
+ Hits 8478 8581 +103
- Misses 1510 1525 +15
- Partials 487 507 +20
Continue to review full report at Codecov.
|
Just missing a change log, otherwise, |
I've fixed the javadocs issues and sharing the |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Simplify DateUtils with ISO8601Utils ([#1837](https://github.com/getsentry/sentry-java/pull/1837)) If none of the above apply, you can opt out of this check by adding |
📜 Description
Replace usage of SimpleDateFormat with a helper class from GSON library.
Closes #1489
💡 Motivation and Context
It is faster and CG friendlier per their own documentation.
Closes #1489
💚 How did you test it?
Current unit tests for date helper class.
📝 Checklist
🔮 Next steps