Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Add shutdownTimeoutMillis in favor of shutdownTimeout #1873

Merged
merged 2 commits into from
Jan 18, 2022
Merged

Ref: Add shutdownTimeoutMillis in favor of shutdownTimeout #1873

merged 2 commits into from
Jan 18, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 18, 2022 •
edited
Loading

📜 Description

Ref: Add shutdownTimeoutMillis in favor of shutdownTimeout

💡 Motivation and Context

Closes #1530

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the base branch from main to 6.x.x January 18, 2022 15:53
@marandaneto marandaneto merged commit ad9f9dc into 6.x.x Jan 18, 2022
@marandaneto marandaneto deleted the ref/add-shutdownTimeoutMillis branch January 18, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@romtsn romtsn romtsn approved these changes

@maciejwalkowiak maciejwalkowiak Awaiting requested review from maciejwalkowiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marandaneto @bruno-garcia @romtsn