Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: screenshots #1967

Merged
merged 21 commits into from
Apr 6, 2022
Merged

Feat: screenshots #1967

merged 21 commits into from
Apr 6, 2022

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 30, 2022

📜 Description

Feat: screenshots
https://develop.sentry.dev/sdk/features/#screenshots=

💡 Motivation and Context

Users may want to see what's in the screen when there's an error or crash.

💚 How did you test it?

Running and unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@marandaneto
Copy link
Contributor Author

cc @brustolin

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno how much you gonna change still, but LGTM except some missing tests 🚀

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #1967 (5626a02) into 6.x.x (1e2a01e) will increase coverage by 0.00%.
The diff coverage is 86.66%.

@@            Coverage Diff            @@
##              6.x.x    #1967   +/-   ##
=========================================
  Coverage     80.61%   80.61%           
- Complexity     2946     2949    +3     
=========================================
  Files           214      214           
  Lines         10928    10939   +11     
  Branches       1451     1456    +5     
=========================================
+ Hits           8810     8819    +9     
  Misses         1592     1592           
- Partials        526      528    +2     
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/MainEventProcessor.java 82.53% <ø> (ø)
sentry/src/main/java/io/sentry/TypeCheckHint.java 0.00% <ø> (ø)
sentry/src/main/java/io/sentry/SentryClient.java 85.84% <85.71%> (-0.19%) ⬇️
sentry/src/main/java/io/sentry/Attachment.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2a01e...5626a02. Read the comment docs.

@marandaneto
Copy link
Contributor Author

cc @brustolin

Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Pretty clean and straight forward.
I think we won't have a problem to implement this on cocoa for manual error capture.

@marandaneto marandaneto marked this pull request as ready for review April 5, 2022 12:49
@marandaneto marandaneto requested a review from romtsn April 5, 2022 12:49
Copy link

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 4414ba0 into 6.x.x Apr 6, 2022
@marandaneto marandaneto deleted the feat/screenshots branch April 6, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants