Feat/profiling fixes #1997
Merged
Feat/profiling fixes #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
profiling trace folder is now created regardless of profiling enabled option (manual initialisation happens after folder creation, so we were losing profiling, if set manually)
profiling trace folder is now created regardless of profiling enabled option (manual initialisation happens after folder creation, so we were losing profiling, if set manually)
marandaneto
reviewed
Apr 20, 2022
sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java
Outdated
Show resolved
Hide resolved
moved profilingTracesDirPath from SentryAndroidOptions to SentryOptions
moved profilingTracesDirPath from SentryAndroidOptions to SentryOptions
marandaneto
reviewed
Apr 21, 2022
sentry-android-core/src/test/java/io/sentry/android/core/AndroidTransactionProfilerTest.kt
Outdated
Show resolved
Hide resolved
|
@romtsn would you like to do a final review? :) |
romtsn
approved these changes
Apr 25, 2022
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
Codecov Report
@@ Coverage Diff @@
## 6.x.x #1997 +/- ##
============================================
- Coverage 80.80% 80.79% -0.02%
- Complexity 3127 3131 +4
============================================
Files 228 228
Lines 11603 11619 +16
Branches 1552 1555 +3
============================================
+ Hits 9376 9387 +11
- Misses 1647 1648 +1
- Partials 580 584 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
reduced profiling sampling rate from 300hz to 100hz
profiling trace folder is now created regardless of profiling enabled option
💡 Motivation and Context
Manual initialisation happens after profiling traces folder creation, so we were losing profiling when it was set manually, as the traces folder was not being created
💚 How did you test it?
Running a sample with strict mode did not complain about folder creation
📝 Checklist