-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change order of event filtering mechanisms #2001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2001 +/- ##
============================================
- Coverage 80.79% 80.77% -0.02%
Complexity 3131 3131
============================================
Files 228 228
Lines 11619 11622 +3
Branches 1555 1556 +1
============================================
+ Hits 9387 9388 +1
Misses 1648 1648
- Partials 584 586 +2
Continue to review full report at Codecov.
|
4 tasks
adinauer
commented
Apr 22, 2022
marandaneto
reviewed
Apr 25, 2022
adinauer
commented
Apr 26, 2022
romtsn
approved these changes
May 3, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Event drop vs session update inconsistencies have been discussed in the Client Infra TSC. Python implementation has been updated to serve as reference implementation. We now only want to update the session when an event is dropped due to sampling but not if it is dropped due to any other filtering mechanism (
beforeSend
,eventProcessor
,ignoredExceptionsForType
). Also the order of the filtering mechanisms should be aligned across SDKs.💡 Motivation and Context
Fixes: #1916
More Info:
💚 How did you test it?
📝 Checklist
🔮 Next steps