-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AndroidTransactionProfiler is now initialized the first time a transa… #2009
Conversation
…ction is started, since in the constructor we don't have the options, yet
…ction is started, since in the constructor we don't have the options, yet
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2009 +/- ##
=========================================
Coverage 80.79% 80.79%
Complexity 3131 3131
=========================================
Files 228 228
Lines 11619 11619
Branches 1555 1555
=========================================
Hits 9387 9387
Misses 1648 1648
Partials 584 584 Continue to review full report at Codecov.
|
@stefanosiano would you mind using the PR template to explain why this is needed? |
Yeah, you are right. I wrote it in the description, but i added the template now |
@stefanosiano We always add a test for a regression, would you mind adding it? thanks. |
📜 Description
AndroidTransactionProfiler is now initialized the first time a transaction is started, since in the constructor we don't have the options, yet
💡 Motivation and Context
When
AndroidTransactionProfiler
is created and set in the options, in theAndroidOptionsInitializer
, we don't know what options were set throughSentryAndroid.init()
yet, as the profiler is created right before it.We can set the internal variables of the profiler that depends on the options on the first profile, as we would be sure to already have all options set up.
💚 How did you test it?
I'm building some ui tests (that will be released in another pr)
📝 Checklist