Calling Sentry.init and specifying contextTags now has an effect on the Log4j SentryAppender

[adinauer]

📜 Description

No longer used the contextTags property in SentryAppender, instead get via Options from HubAdapter.

💡 Motivation and Context

Fix #2043 for Log4j

💚 How did you test it?

Demo code

📝 Checklist

• I reviewed the submitted code
• I added tests to verify the changes
• I updated the docs if needed
• No breaking changes

🔮 Next steps

[romtsn]

brrrr, this feels wrong again, having to maintain 2 different properties for the same purpose 🤣

Would it be possible to set contextTags directly on the hub in the SentryAppender constructor? This way we could eliminate the field contextTags and wouldn't need to set it in start.

Although this could be a problem if the appender was initialized but never started, we still set the contextTags on the hub, don't know if that can be ever the case

[adinauer]

brrrr, this feels wrong again, having to maintain 2 different properties for the same purpose 🤣

Would it be possible to set contextTags directly on the hub in the SentryAppender constructor? This way we could eliminate the field contextTags and wouldn't need to set it in start.

Although this could be a problem if the appender was initialized but never started, we still set the contextTags on the hub, don't know if that can be ever the case

I've added something to #2053 , should we deal with this at a later time?

[romtsn]

brrrr, this feels wrong again, having to maintain 2 different properties for the same purpose 🤣
Would it be possible to set contextTags directly on the hub in the SentryAppender constructor? This way we could eliminate the field contextTags and wouldn't need to set it in start.
Although this could be a problem if the appender was initialized but never started, we still set the contextTags on the hub, don't know if that can be ever the case

I've added something to #2053 , should we deal with this at a later time?

Yeah sure, was just a quick suggestion, but we can do it later

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (6.x.x@6b3fd20). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             6.x.x    #2054   +/-   ##
========================================
  Coverage         ?   81.07%           
  Complexity       ?     3217           
========================================
  Files            ?      230           
  Lines            ?    11821           
  Branches         ?     1572           
========================================
  Hits             ?     9584           
  Misses           ?     1650           
  Partials         ?      587           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b3fd20...c3e71d6. Read the comment docs.

[adinauer]

brrrr, this feels wrong again, having to maintain 2 different properties for the same purpose 🤣
Would it be possible to set contextTags directly on the hub in the SentryAppender constructor? This way we could eliminate the field contextTags and wouldn't need to set it in start.
Although this could be a problem if the appender was initialized but never started, we still set the contextTags on the hub, don't know if that can be ever the case

I've added something to #2053 , should we deal with this at a later time?

Yeah sure, was just a quick suggestion, but we can do it later

I like the suggestion but I'm not sure about the consequences so I don't wanna rush it. The quick fix should suffice for now I hope.

[maciejwalkowiak]

I believe it should be put on hold until #2052 (review) is resolved, so that we have ideally one consistent approach between logging frameworks.