Sentry recovers after a Thread had currentHub set to a NoOpHub #2076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
When a call to
Sentry
happens beforeSentry.init
, thecurrentHub
is set to aNoOpHub
. IfSentry.init
is then called in a different thread, the thread whereSentry
was called beforeinit
is poisoned without this change. By checking if thecurrentHub
is aNoOpHub
we can allow the poisoned thread to self heal.💡 Motivation and Context
Happened to a customer who set up a thread pool and had executions happen before being able to initialize Sentry.
💚 How did you test it?
Unit Test
📝 Checklist
🔮 Next steps
Discuss if this has any consequences I can't see.