Use charset string to support Android 16 #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arlier Android versions
bruno-garcia
changed the title
bruno-garcia
approved these changes
Jun 20, 2022
marandaneto
reviewed
Jun 20, 2022
| @@ -16,7 +15,7 @@ | |||
| @ApiStatus.Experimental | |||
| public final class Baggage { | |||
|
|
|||
| static final @NotNull String CHARSET = StandardCharsets.UTF_8.toString(); | |||
| static final @NotNull String CHARSET = "UTF-8"; | |||
There was a problem hiding this comment.
Suggested change
| static final @NotNull String CHARSET = "UTF-8"; | |
| private static final Charset UTF_8 = Charset.forName("UTF-8"); |
Just because that's how we use it everywhere, so we keep the pattern.
There was a problem hiding this comment.
Can't because of
Usage of API documented as @ since 10+
when using your suggestion it uses another method here:
URLDecoder.decode(value, UTF_8)
There was a problem hiding this comment.
That's fine, our SDK is 14+ (10 years old)
There was a problem hiding this comment.
This is about JDK version, not Android version.
marandaneto
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use charset string directly as StandardCharsets is not available on earlier Android versions
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps