Only send userid in Dynamic Sampling Context if sendDefaultPii is true #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## feat/add-sample-rate-to-baggage #2147 +/- ##
==================================================================
Coverage 80.94% 80.94%
- Complexity 3288 3290 +2
==================================================================
Files 233 233
Lines 12041 12044 +3
Branches 1595 1594 -1
==================================================================
+ Hits 9746 9749 +3
Misses 1712 1712
Partials 583 583
Continue to review full report at Codecov.
|
philipphofmann
approved these changes
Jun 30, 2022
| @@ -500,6 +501,29 @@ class SentryTracerTest { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| fun `returns trace state without userId if not send pii`() { | |||
There was a problem hiding this comment.
l: For full conditional coverage you could also add a test if the user is null and isSendDefaultPii = true, but maybe that's overkill. Up to you.
There was a problem hiding this comment.
added returns baggage header without userId if send pii and null user below
6 tasks
adinauer
added a commit
that referenced
this pull request
Jul 1, 2022
…atten user (#2135) * Add sample rate to baggage and trace in envelope header; flatten user * Add changelog * Use _ for baggage keys * Commit tests * Feat/traces sampler into sample rate (#2141) * Commit tests * Add sample rate from traces sampler to DSC * Do not replace null with true/false * Restore sample rate in OutboxSender * Remove fallback for sampling decision from TraceContext * Remove sample rate fallback from TracesSamplingDecision * Test more envelope header trace fields for OutboxSender * CR changes * Fix changelog * Only send userid in Dynamic Sampling Context if sendDefaultPii is true (#2147) * Skip sending userId in DSC if send default pii is off * Add changelog * Add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
See getsentry/develop#625
💡 Motivation and Context
Replaces #2145 and not only skips
userIdinbaggagebut also in the envelope headertrace.💚 How did you test it?
📝 Checklist
🔮 Next steps