-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate event.modules with dependencies metadata #2324
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
Previous results on branch: feat/events-with-modules
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c39aba1 | 278.92 ms | 344.45 ms | 65.53 ms |
2123a10 | 289.38 ms | 332.15 ms | 42.77 ms |
a9f906d | 303.51 ms | 347.83 ms | 44.32 ms |
ed1e498 | 339.26 ms | 385.94 ms | 46.68 ms |
6b29365 | 270.37 ms | 291.50 ms | 21.13 ms |
6523b55 | 344.06 ms | 372.39 ms | 28.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c39aba1 | 1.73 MiB | 2.32 MiB | 609.83 KiB |
2123a10 | 1.73 MiB | 2.32 MiB | 609.94 KiB |
a9f906d | 1.73 MiB | 2.32 MiB | 609.84 KiB |
ed1e498 | 1.73 MiB | 2.32 MiB | 609.76 KiB |
6b29365 | 1.73 MiB | 2.32 MiB | 610.00 KiB |
6523b55 | 1.73 MiB | 2.32 MiB | 609.94 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, LGTM!
...-android-core/src/main/java/io/sentry/android/core/internal/modules/AssetsModulesLoader.java
Outdated
Show resolved
Hide resolved
...ndroid-core/src/test/java/io/sentry/android/core/internal/modules/AssetsModulesLoaderTest.kt
Outdated
Show resolved
Hide resolved
sentry/src/test/java/io/sentry/internal/modules/ResourcesModulesLoaderTest.kt
Outdated
Show resolved
Hide resolved
...-android-core/src/main/java/io/sentry/android/core/internal/modules/AssetsModulesLoader.java
Show resolved
Hide resolved
Codecov ReportBase: 80.25% // Head: 80.29% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
============================================
+ Coverage 80.25% 80.29% +0.04%
- Complexity 3479 3497 +18
============================================
Files 247 250 +3
Lines 12909 12969 +60
Branches 1735 1740 +5
============================================
+ Hits 10360 10414 +54
- Misses 1892 1897 +5
- Partials 657 658 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
📜 Description
sentry-external-modules.txt
file ingested by the gradle plugin into the final jar/apk💡 Motivation and Context
Closes #1470
Relates to getsentry/sentry-android-gradle-plugin#396
Part of getsentry/team-mobile#54
💚 How did you test it?
📝 Checklist
🔮 Next steps