-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't sent device name if DefaultPII is disabled #2354
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 301.51 ms | 346.60 ms | 45.09 ms |
a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
7597ded | 289.60 ms | 339.69 ms | 50.09 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
38e4f11 | 358.20 ms | 433.73 ms | 75.53 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f809aac | 1.73 MiB | 2.32 MiB | 608.63 KiB |
a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
7597ded | 1.73 MiB | 2.32 MiB | 609.88 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
38e4f11 | 1.73 MiB | 2.32 MiB | 609.82 KiB |
Codecov ReportBase: 80.36% // Head: 80.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
=========================================
Coverage 80.36% 80.36%
Complexity 3670 3670
=========================================
Files 290 290
Lines 13712 13712
Branches 1801 1801
=========================================
Hits 11020 11020
Misses 2001 2001
Partials 691 691 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic seems flipped. Could you please also add an entry to the changelog?
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
1035e1c
to
ddd3cf8
Compare
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
ddd3cf8
to
d156d8a
Compare
📜 Description
💡 Motivation and Context
closes #2063
💚 How did you test it?
📝 Checklist