-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ThreadLocalAccessor
in Spring Boot 3 WebFlux sample
#2569
Merged
adinauer
merged 5 commits into
feat/support-thread-local-accessor-for-reactor
from
feat/use-thread-local-accessor-in-webflux-sample
Mar 1, 2023
Merged
Use ThreadLocalAccessor
in Spring Boot 3 WebFlux sample
#2569
adinauer
merged 5 commits into
feat/support-thread-local-accessor-for-reactor
from
feat/use-thread-local-accessor-in-webflux-sample
Mar 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
changed the base branch from
main
to
feat/support-thread-local-accessor-for-reactor
February 24, 2023 10:58
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7620651 | 325.24 ms | 359.59 ms | 34.35 ms |
14b93a6 | 305.29 ms | 334.71 ms | 29.43 ms |
b3f3d7a | 336.37 ms | 387.04 ms | 50.67 ms |
05b9e20 | 343.67 ms | 366.00 ms | 22.33 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7620651 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
14b93a6 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
b3f3d7a | 1.73 MiB | 2.34 MiB | 626.30 KiB |
05b9e20 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
Previous results on branch: feat/use-thread-local-accessor-in-webflux-sample
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2e82a91 | 301.84 ms | 359.88 ms | 58.04 ms |
02d7ab6 | 307.38 ms | 333.83 ms | 26.45 ms |
09f597a | 284.63 ms | 359.79 ms | 75.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2e82a91 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
02d7ab6 | 1.73 MiB | 2.34 MiB | 626.30 KiB |
09f597a | 1.73 MiB | 2.34 MiB | 626.30 KiB |
Codecov ReportBase: 80.32% // Head: 80.35% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## feat/support-thread-local-accessor-for-reactor #2569 +/- ##
====================================================================================
+ Coverage 80.32% 80.35% +0.02%
- Complexity 4009 4011 +2
====================================================================================
Files 332 332
Lines 15148 15148
Branches 1979 1979
====================================================================================
+ Hits 12168 12172 +4
+ Misses 2201 2197 -4
Partials 779 779
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
February 27, 2023 05:23
…at/use-thread-local-accessor-in-webflux-sample
…at/use-thread-local-accessor-in-webflux-sample
cleptric
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
Use
ThreadLocalAccessor
in Spring Boot 3 WebFlux sample💡 Motivation and Context
To showcase how
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps