Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ThreadLocalAccessor in Spring Boot 3 WebFlux sample #2569

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Feb 24, 2023

#skip-changelog

📜 Description

Use ThreadLocalAccessor in Spring Boot 3 WebFlux sample

💡 Motivation and Context

To showcase how

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to feat/support-thread-local-accessor-for-reactor February 24, 2023 10:58
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a02340

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 359.60 ms 468.02 ms 108.42 ms
Size 1.73 MiB 2.34 MiB 626.30 KiB

Baseline results on branch: feat/support-thread-local-accessor-for-reactor

Startup times

Revision Plain With Sentry Diff
7620651 325.24 ms 359.59 ms 34.35 ms
14b93a6 305.29 ms 334.71 ms 29.43 ms
b3f3d7a 336.37 ms 387.04 ms 50.67 ms
05b9e20 343.67 ms 366.00 ms 22.33 ms

App size

Revision Plain With Sentry Diff
7620651 1.73 MiB 2.34 MiB 626.30 KiB
14b93a6 1.73 MiB 2.34 MiB 626.30 KiB
b3f3d7a 1.73 MiB 2.34 MiB 626.30 KiB
05b9e20 1.73 MiB 2.34 MiB 626.30 KiB

Previous results on branch: feat/use-thread-local-accessor-in-webflux-sample

Startup times

Revision Plain With Sentry Diff
2e82a91 301.84 ms 359.88 ms 58.04 ms
02d7ab6 307.38 ms 333.83 ms 26.45 ms
09f597a 284.63 ms 359.79 ms 75.16 ms

App size

Revision Plain With Sentry Diff
2e82a91 1.73 MiB 2.34 MiB 626.30 KiB
02d7ab6 1.73 MiB 2.34 MiB 626.30 KiB
09f597a 1.73 MiB 2.34 MiB 626.30 KiB

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 80.32% // Head: 80.35% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9a2d1a4) compared to base (9d43bb9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                                 Coverage Diff                                  @@
##             feat/support-thread-local-accessor-for-reactor    #2569      +/-   ##
====================================================================================
+ Coverage                                             80.32%   80.35%   +0.02%     
- Complexity                                             4009     4011       +2     
====================================================================================
  Files                                                   332      332              
  Lines                                                 15148    15148              
  Branches                                               1979     1979              
====================================================================================
+ Hits                                                  12168    12172       +4     
+ Misses                                                 2201     2197       -4     
  Partials                                                779      779              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Sentry.java 56.08% <0.00%> (+1.05%) ⬆️
sentry/src/main/java/io/sentry/HubAdapter.java 9.23% <0.00%> (+3.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adinauer adinauer merged commit 5b12e27 into feat/support-thread-local-accessor-for-reactor Mar 1, 2023
@adinauer adinauer deleted the feat/use-thread-local-accessor-in-webflux-sample branch March 1, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants